Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template ocean volumes & mounts #118

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Template ocean volumes & mounts #118

merged 3 commits into from
Jun 13, 2024

Conversation

yairsimantov20
Copy link
Contributor

Description

  • Allow templating when mounting volumes & volumemounts
  • Added the ability to decide if the secret should be created even when useExistingSecret is false (Can be done with extra envs)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

stavbernazport
stavbernazport approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@stavbernazport stavbernazport left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@yairsimantov20 yairsimantov20 merged commit 15a74b3 into main Jun 13, 2024
1 check passed
@Tankilevitch Tankilevitch mentioned this pull request Jun 13, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavbernazport stavbernazport stavbernazport approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairsimantov20 @stavbernazport