Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added self signed certificates values documentation in README #105

Merged

Conversation

stavbernazport
Copy link
Member

Description

What - Added documentation for newly added feature - self signed certificate with existing secret
Why -
How -

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

@stavbernazport stavbernazport requested a review from MPTG94 May 19, 2024 07:39
@stavbernazport stavbernazport force-pushed the update-ocean-chart-readme-selfsigned-cert-secret branch 4 times, most recently from f8286c2 to 86d1ce4 Compare May 19, 2024 07:46
@stavbernazport stavbernazport force-pushed the update-ocean-chart-readme-selfsigned-cert-secret branch from 86d1ce4 to 7681454 Compare May 19, 2024 07:47
Copy link
Member

@MPTG94 MPTG94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stavbernazport stavbernazport merged commit e81355d into main May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants