Merge pull request #60 from port-labs/PORT-5836-ocean-ingressclassname

added ingressclassname for ocean
port-labs · Dec 31, 2023 · 30e2d0a · 30e2d0a
2 parents c6a9b62 + 12ca5fe
commit 30e2d0a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 1 deletion.
diff --git a/.github/workflows/validate-ocean.yml b/.github/workflows/validate-ocean.yml
@@ -28,4 +28,4 @@ jobs:
 
     - name: Validate Helm Chart
       run: |
-        helm template --set secret.secrets.portClientId=test --set secret.secrets.portClientSecret=test --set configMap.config=test . | kubectl apply --dry-run=client -f -
+        helm template --set port.clientId=test --set port.clientSecret=test --set configMap.config=test . | kubectl apply --dry-run=client -f -
diff --git a/charts/port-ocean/README.md b/charts/port-ocean/README.md
@@ -68,6 +68,7 @@ The following table lists the configuration parameters of the `port-ocean` chart
 | `service.type`             | Service type for the Port application.                                                                                                                                                                                                                                                                                                                                                                                                                                                             | `ClusterIP`                 |
 | `service.port`             | Port number for the service.                                                                                                                                                                                                                                                                                                                                                                                                                                                                       | `8000`                      |
 | `ingress.enabled`          | Specifies whether the ingress is enabled or not.                                                                                                                                                                                                                                                                                                                                                                                                                                                   | `false`                     |
+| `ingress.className`          | Specifies the ingress ClassName.                                                                                                                                                                                                                                                                                                                                                                                                                                                    | `""`                     |
 | `ingress.annotations`      | Annotations for the ingress object.                                                                                                                                                                                                                                                                                                                                                                                                                                                                | `{}`                        |
 | `ingress.host`             | Hostname for the ingress.                                                                                                                                                                                                                                                                                                                                                                                                                                                                          | `null`                      |
 | `ingress.path`             | Path for the ingress.                                                                                                                                                                                                                                                                                                                                                                                                                                                                              | `/`                         |

diff --git a/charts/port-ocean/templates/ingress.yaml b/charts/port-ocean/templates/ingress.yaml
@@ -11,6 +11,9 @@ metadata:
       {{- toYaml .Values.ingress.annotations | nindent 4 }}
     {{- end }}
 spec:
+    {{- if .Values.ingress.className }}
+    ingressClassName: {{ .Values.ingress.className | quote }}
+    {{- end }}
     rules:
         - 
           {{- if .Values.ingress.host }}

diff --git a/charts/port-ocean/values.yaml b/charts/port-ocean/values.yaml
@@ -59,6 +59,7 @@ service:
 
 ingress:
   enabled: false
+  className: ""
   annotations: {}
   host: null
   path: /