-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build for pypi instead of conda #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first half is great, I think templating the conda recipe is fine, but I'm not super comfortable with the script as it stands. The translation of pypi packages to conda packages feels risky, I think it'd be better to completely switch everything over to conda if possible, or I'd feel better about maintaining a json map or something.
I'd prefer a templating engine, or if not I think there should be tests for the templating. Build up the string completely, then write it. There's not much memory benefit doing it line by line.
I didn't intend to make the But I'm happy to keep
The Hail team maintains a pip package, so it would make sense to switch to pip entirely. One downside is that pip doesn't have channels, so we would have to prefix the package name, e.g. Ideally we don't want to diverge from the official release and have two packages. But not sure if that's possible. Currently there are a couple of |
Co-authored-by: Michael Franklin <[email protected]>
Co-authored-by: Michael Franklin <[email protected]>
Modified the workflow to build |
Simplify maintaining the conda package recipe: instead of manually changing the list of dependencies, populate them automatically from the pip requirements list.Build
cpg-hail
pip package instead of conda.