Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:WebSerialAPIに対応していないブラウザで開くと警告のモーダルを出す #331

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat:WebSerialAPIに対応していないブラウザで開くと警告のモーダルを出す #331

wants to merge 14 commits into from
+59 −3

Conversation

kiharu3112
Copy link
Contributor

@kiharu3112 kiharu3112 commented Dec 1, 2024 •
edited
Loading

close #95
image
image

@kiharu3112 kiharu3112 requested review from laminne and tufusa and removed request for laminne December 1, 2024 14:32
@kiharu3112 kiharu3112 added the enhancement New feature or request label Dec 1, 2024
@kiharu3112 kiharu3112 self-assigned this Dec 1, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 1, 2024 •
edited
Loading

Deploying kaniwriter with  Cloudflare Pages  Cloudflare Pages

Latest commit: dfbdaa8
Status: ✅  Deploy successful!
Preview URL: https://3149cf1f.kaniwriter.pages.dev
Branch Preview URL: https://feat-95-warning-for-unsuppor.kaniwriter.pages.dev

View logs

@kiharu3112 kiharu3112 enabled auto-merge December 1, 2024 14:34
@kiharu3112
Copy link
Contributor Author

なんで放置してたか思い出した
image

tufusa
tufusa requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@tufusa tufusa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • デフォルトでフォーカスが合った状態になるようで、ブラウザによっては枠線が表示されます。
  • 幅が狭い環境でテキストと×アイコンが重なってしまうようです。
    image

i18n/locales/ja.json Outdated Show resolved Hide resolved
src/components/UnsupportedBrowserModal.tsx Outdated Show resolved Hide resolved
src/pages/home.tsx Outdated Show resolved Hide resolved
src/pages/home.tsx Outdated Show resolved Hide resolved
src/components/UnsupportedBrowserModal.tsx Outdated Show resolved Hide resolved
@kiharu3112 kiharu3112 requested a review from tufusa December 10, 2024 05:19
@kiharu3112 kiharu3112 requested a review from tufusa December 10, 2024 05:43
@kiharu3112 kiharu3112 disabled auto-merge December 10, 2024 06:56
@kiharu3112
chore:UnsupportedBrowserModalコンポーネントの最大幅を設定し、フォントサイズを変更
dfbdaa8 
幅が狭い環境でテキストと×アイコンが重なってしまうため
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laminne laminne Awaiting requested review from laminne

@speak-mentaiko speak-mentaiko Awaiting requested review from speak-mentaiko

@Suzune2741 Suzune2741 Awaiting requested review from Suzune2741

@tufusa tufusa Awaiting requested review from tufusa

Requested changes must be addressed to merge this pull request.

Assignees

@kiharu3112 kiharu3112

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat:対応していない端末で開くと警告を表示する
2 participants
@kiharu3112 @tufusa