This repository has been archived by the owner on Apr 24, 2019. It is now read-only.
Update to Koa 2 #57
Open
Update to Koa 2 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling e8a6d36 on edorivai:master into ** on popomore:master**. |
|
Changes Unknown when pulling 5bac2f9 on edorivai:master into ** on popomore:master**. |
|
Changes Unknown when pulling fbef5fe on edorivai:master into ** on popomore:master**. |
|
Changes Unknown when pulling 2a717ca on edorivai:master into ** on popomore:master**. |
|
Please get this merged or publish the fork on NPM. <3 |
|
Can we get this merged? |
|
Since @popomore has apparently abandoned koa-proxy, could you see if npm would transfer the package name to you for you to take the project over? I think it would be much appreciated! |
|
@chrisveness I've emailed @popomore, and CC'd npm support. On their disputes page, npm indicates it may take a couple of weeks, so stay tuned! |
fixes yarn install warning `warning " > [email protected]" has incorrect peer dependency "koa@>2".`
fix koa peerDependency error
Feature: allow setting or overriding response headers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to upgrading to Koa 2.
Solves #37
Summary
Problems
I have all test passing, except the
encodingtest. The problem with this test is that if you want to decode the response body, you'll have to wait for the entire stream to finish. I'm not sure whether decoding the response body should really part of this library. One could simply decode in an upstream middleware if they want, right?So I have commented out the decoding, and switched the test to pending. Please let me know if you want to keep support for decoding, we can discuss options.
Version
I guess this would be a major version bump, since it will require Koa 2.