fix: update libcosmic #1128
Annotations
10 warnings
taken reference of right operand:
cosmic-app-list/cosmic-app-list-config/src/lib.rs#L45
warning: taken reference of right operand
--> cosmic-app-list/cosmic-app-list-config/src/lib.rs:45:63
|
45 | if let Some(pos) = self.favorites.iter().position(|e| e == &id) {
| ^^^^^---
| |
| help: use the right value directly: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `#[warn(clippy::op_ref)]` on by default
|
unused import: `text`:
cosmic-applet-a11y/src/app.rs#L21
warning: unused import: `text`
--> cosmic-applet-a11y/src/app.rs:21:25
|
21 | widget::{container, text},
| ^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
unused import: `hash::Hash`:
cosmic-applet-a11y/src/backend/mod.rs#L14
warning: unused import: `hash::Hash`
--> cosmic-applet-a11y/src/backend/mod.rs:14:23
|
14 | use std::{fmt::Debug, hash::Hash};
| ^^^^^^^^^^
|
unused import: `Result`:
cosmic-applet-a11y/src/backend/mod.rs#L16
warning: unused import: `Result`
--> cosmic-applet-a11y/src/backend/mod.rs:16:24
|
16 | use zbus::{Connection, Result};
| ^^^^^^
|
this `if` statement can be collapsed:
cosmic-applet-audio/src/mouse_area.rs#L303
warning: this `if` statement can be collapsed
--> cosmic-applet-audio/src/mouse_area.rs:303:9
|
303 | / if !state.is_out_of_bounds {
304 | | if widget
305 | | .on_mouse_enter
306 | | .as_ref()
... |
317 | | }
318 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
303 ~ if !state.is_out_of_bounds && widget
304 + .on_mouse_enter
305 + .as_ref()
306 + .or(widget.on_mouse_exit.as_ref())
307 + .is_some() {
308 + if let Event::Mouse(mouse::Event::CursorMoved { .. }) = event {
309 + state.is_out_of_bounds = true;
310 + if let Some(message) = widget.on_mouse_exit.as_ref() {
311 + shell.publish(message.clone());
312 + }
313 + return event::Status::Captured;
314 + }
315 + }
|
|
unused variable: `space_xxs`:
cosmic-applet-a11y/src/app.rs#L189
warning: unused variable: `space_xxs`
--> cosmic-applet-a11y/src/app.rs:189:13
|
189 | space_xxs, space_s, ..
| ^^^^^^^^^-
| |
| help: try removing the field
|
= note: `#[warn(unused_variables)]` on by default
|
unused variable: `space_s`:
cosmic-applet-a11y/src/app.rs#L189
warning: unused variable: `space_s`
--> cosmic-applet-a11y/src/app.rs:189:24
|
189 | space_xxs, space_s, ..
| ^^^^^^^-
| |
| help: try removing the field
|
field `icon_name` is never read:
cosmic-applet-a11y/src/app.rs#L36
warning: field `icon_name` is never read
--> cosmic-applet-a11y/src/app.rs:36:5
|
34 | struct CosmicA11yApplet {
| ---------------- field in this struct
35 | core: cosmic::app::Core,
36 | icon_name: String,
| ^^^^^^^^^
|
= note: `CosmicA11yApplet` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
variants `Errored` and `OpenSettings` are never constructed:
cosmic-applet-a11y/src/app.rs#L48
warning: variants `Errored` and `OpenSettings` are never constructed
--> cosmic-applet-a11y/src/app.rs:48:5
|
45 | enum Message {
| ------- variants in this enum
...
48 | Errored(String),
| ^^^^^^^
...
52 | OpenSettings,
| ^^^^^^^^^^^^
|
= note: `Message` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
|
field `0` is never read:
cosmic-applet-audio/src/pulse.rs#L453
warning: field `0` is never read
--> cosmic-applet-audio/src/pulse.rs:453:16
|
453 | IterateErr(IterateResult),
| ---------- ^^^^^^^^^^^^^
| |
| field in this variant
|
= note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
453 | IterateErr(()),
| ~~
|