Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix initial build #14

Merged
merged 3 commits into from
Nov 20, 2023
Merged

fix initial build #14

merged 3 commits into from
Nov 20, 2023

Conversation

soltanireza65
Copy link
Contributor

@soltanireza65 soltanireza65 commented Nov 20, 2023 •
edited
Loading

  • Removed unused dependencies
  • Removed test related utilities
  • Fix separation of dev dependencies and dependencies
  • Also updated the typescript version
  • Installed @types/jest because @noeldemartin/utils has a dependency on it

Fixes Link to issue

@michielbdejong
Copy link
Member

Can you say a bit more about how it fixes #13? What was the problem?

@michielbdejong
Copy link
Member

michielbdejong commented Nov 20, 2023 •
edited
Loading

Also fixes #15 by removing a few files from src that shouldn't be there ("test related utilities")

@michielbdejong
Copy link
Member

Regarding the @types/jest devDependency, probably NoelDeMartin/utls uses version 27 and we require version 29 to have jest.Mock available?

@michielbdejong
Copy link
Member

OK, we don't understand exacly how but we see that this cleanup fixes both #13 and #15. \o/

@michielbdejong michielbdejong merged commit bbe3456 into main Nov 20, 2023
@michielbdejong michielbdejong deleted the fix/init-build branch November 20, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michielbdejong michielbdejong michielbdejong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Namespace 'NodeJS' has no exported member 'Global'.
2 participants
@soltanireza65 @michielbdejong