{PROD4POD-1931} Add tests for poly-importer

feature-utils/poly-import/package.json

@@ -6,5 +6,15 @@
   "scripts": {
     "build": "rollup -c rollup.config.js",
     "test": "jest --coverage"
+  },
+  "jest": {
+    "verbose": true,
+    "transform": {
+      "\\.[jt]sx?$": "babel-jest"
+    },
+    "testEnvironment": "jsdom"
+  },
+  "devDependencies": {
+    "@polypoly-eu/api": "file:../../platform/feature-api/api"
   }
 }

feature-utils/poly-import/src/errors/polyIn-errors.js

@@ -2,26 +2,24 @@ class PolyImportError extends Error {
     constructor(type, cause) {
         super(`Failed to ${type} file`);
         this.cause = cause;
+        this.name = this.constructor.name;
     }
 }
 
 export class FileImportError extends PolyImportError {
     constructor(cause) {
         super("import", cause);
-        this.name = "FileImportError";
     }
 }
 
 export class FileSelectionError extends PolyImportError {
     constructor(cause) {
         super("select", cause);
-        this.name = "FileSelectionError";
     }
 }
 
 export class RefreshFilesError extends PolyImportError {
     constructor(cause) {
         super("refresh", cause);
-        this.name = "RefreshFilesError";
     }
 }

feature-utils/poly-import/src/importer.js

@@ -3,7 +3,7 @@ import { Telemetry } from "../utils/performance-telemetry";
 
 export class Importer {
     async import({ zipFile, dataAccount }) {
-        throw new Error(
+        throw new TypeError(
             `Calling abstract base class with ${zipFile}, ${dataAccount}`
         );
     }

feature-utils/poly-import/test/importer.test.js

@@ -0,0 +1,11 @@
+import { Importer } from "../src";
+
+describe("Importer can't be instantiated ", () => {
+    it("throws a TypeError", async () => {
+        try {
+            await new Importer().import({ zipFile: null, dataAccount: null });
+        } catch (e) {
+            expect(e).toBeInstanceOf(TypeError);
+        }
+    });
+});

feature-utils/poly-import/test/polyIn-errors.test.js

@@ -0,0 +1,23 @@
+import { FileImportError, FileSelectionError, RefreshFilesError } from "../src";
+
+const classData = [
+    [FileImportError, "import"],
+    [FileSelectionError, "select"],
+    [RefreshFilesError, "refresh"],
+];
+
+describe("Errors have the right API ", () => {
+    it("throw correctly their type errors", () => {
+        classData.forEach(([testClass, testMsg]) => {
+            const testCause = "test";
+            try {
+                throw new testClass(testCause);
+            } catch (error) {
+                expect(error).toBeInstanceOf(testClass);
+                expect(error.message).toMatch(new RegExp(testMsg));
+                expect(error.name).toBe(new testClass().constructor.name);
+                expect(error.cause).toBe(testCause);
+            }
+        });
+    });
+});

feature-utils/poly-import/test/storage.test.js

@@ -0,0 +1,28 @@
+import { polyProtocolRegex } from "@polypoly-eu/api";
+import { MockPod } from "@polypoly-eu/api/dist/mock-pod";
+import { FeatureFileStorage } from "../src";
+
+describe("File storage ", () => {
+    let fileStorage;
+    beforeAll(() => {
+        const pod = new MockPod();
+        fileStorage = new FeatureFileStorage(pod);
+    });
+    it("when instantiated there are no files stored", () => {
+        expect(fileStorage.files).toBeNull;
+    });
+});
+
+describe("File storage", () => {
+    let fileStorage;
+    let fileUri;
+    beforeAll(async () => {
+        const pod = new MockPod();
+        fileUri = await pod.polyOut.importArchive("noRealFile.zip");
+        fileStorage = new FeatureFileStorage(pod);
+    });
+    it("ignores non-existent archives", () => {
+        expect(fileUri).toMatch(polyProtocolRegex);
+        expect(fileStorage.files).toBeNull;
+    });
+});

feature-utils/poly-import/test/telemetry.test.js

@@ -0,0 +1,14 @@
+import { Telemetry } from "../src";
+
+describe("Telemetry measures performance ", () => {
+    let telemetry;
+    beforeAll(() => {
+        telemetry = new Telemetry();
+    });
+
+    it("Returns increasing elapsed time", () => {
+        const oldTime = telemetry.elapsedTime();
+        expect(oldTime).toBeGreaterThan(0);
+        expect(telemetry.elapsedTime()).toBeGreaterThan(oldTime);
+    });
+});

features/facebookImport/test/ministory/report-metadata.test.js

@@ -43,6 +43,7 @@ describe("Report metadata analysis", () => {
                 ),
             ],
         ]);
+        console.log(zipFile);
         const { facebookAccount, analysisResult } = await runAnalysisForExport(
             ReportMetadataAnalysis,
             zipFile

platform/feature-api/api/src/pod-api/uri.ts

@@ -9,8 +9,8 @@ export function createUUID(): string {
     return uuidv4();
 }
 
-const polyProtocol = "polypod://";
-const polyProtocolRegex = new RegExp(`^${polyProtocol}`);
+export const polyProtocol = "polypod://";
+export const polyProtocolRegex = new RegExp(`^${polyProtocol}`);
 
 /**
  *