Fix EMA updating

[dshiell]

We should always update the gas price limits or they will never decrease.

Summary by CodeRabbit

• New Features

  • Enhanced fee management logic for improved transaction processing.
  • Streamlined calculations for gas price and blob price limits.

• Bug Fixes

  • Ensured correct population of transaction arguments with updated gas limits.

• Documentation

  • Added comments for improved clarity in fee management logic.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request focus on enhancing the fee management logic within the src/server.ts file, specifically in the feesTooHigh function. New calculations for transaction gas price and blob price limits have been introduced, ensuring that these limits are updated before any conditional checks are made. The handleEthSignTransaction function has also been adjusted to correctly populate transaction arguments. Minor formatting changes and additional comments have been included for clarity, but the overall functionality remains unchanged.

Changes

File	Change Summary
src/server.ts	Enhanced feesTooHigh function with new calculations for TX_GASPRICE_LIMIT and TX_BLOBPRICE_LIMIT. Moved limit calculations before conditional checks and updated logging. Adjusted handleEthSignTransaction for correct transaction argument population. Minor formatting and comments added.

Possibly related PRs

• adding gas limit #4: Introduces new constants for TX_GASPRICE_LIMIT and TX_BLOBPRICE_LIMIT, modifying the feesTooHigh function, directly related to the main PR's changes.
• add exponential weighting on txn price limits #6: Updates the feesTooHigh function to include logic for recalculating TX_GASPRICE_LIMIT and TX_BLOBPRICE_LIMIT, aligning with the main PR's enhancements.

Suggested reviewers

• Inkvi
• jlafiandra6
• alfredo-stonk

🐇 In the land of code where changes bloom,
The gas price limits now find more room.
With fees too high, we swiftly compute,
New limits in place, our logic's astute.
So hop along, let's celebrate this feat,
For clearer code makes our project sweet! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.