This repository has been archived by the owner on Mar 1, 2021. It is now read-only.
Homework was resolved #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otopba
suggested changes
Mar 3, 2019
There was a problem hiding this comment.
Задание сделано хорошо, нужно поправить небольшие замечания что оставлены к коду.
Общие замечания:
- Нет выделение активного элемента в RecyclerView
- Клавиатура перекрывает поля ввода
- При добавлении нового студента нет аватарки
- Если ввести очень длинное имя, верстка расползается
- Пожалуйста, удали из репозитория папку .idea. Это моя изначальная ошибка. Можно забрать изменения из моего репозитория, там исправлена эта проблема
app/src/main/java/ru/ok/technopolis/students/StudentsAdapter.java
Outdated
Show resolved
Hide resolved
otopba
reviewed
Mar 9, 2019
| @@ -46,26 +52,46 @@ protected void onCreate(Bundle savedInstanceState) { | |||
| generateStudentsList(); | |||
| setupRecyclerView(); | |||
|
|
|||
| vibe = (Vibrator) getSystemService(Context.VIBRATOR_SERVICE); | |||
|
Работа принята. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.