-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Pybids 0.7 compatibility #84
MNT: Pybids 0.7 compatibility #84
Conversation
Currently stalled out at bids-standard/pybids#284. |
Co-Authored-By: adelavega <[email protected]>
WIP: Neuroscout related changes
…fitlins into mnt/dependency_updates
Summary of conversation with Tal:
|
Higher-level updates for pybids
@adelavega Given that we can now run simple second-level models, should we green-light a pybids 0.7 release? |
Ummm... I think the functionality is all there, but are the docs up to date? It's a pretty big API change so that's an important piece |
Also, maybe it's time to merge this PR as well, and we can start a new base PR for adding more than 2 levels (I've started working on it a bit) |
Okay, let me give it a cleanup review. |
The main thing missing from previous functionality is some of the plotting-- design matrix correlation plot (no obvious "EVs"), and contrast matrix plotting. I think it would be reasonable to raise issues for restoring the function of those two (I don't personally need them so not a high priority for me) |
There are also some weirdnesses with file naming. e.g.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a quick read through, some notes for myself.
oh, I thought I fixed that. the issue is its using |
Oh, I think you did. I still had some old outputs in my derivatives directory. |
This branch tracks restoration of functionality to FitLins, using derivatives from fMRIPrep 1.2.1 and models updated according to the draft BIDS model spec.
The ds114 model will be updated as needed in bids-standard/bids-examples#130.
Needed modifications to fMRIPrep derivatives are being tracked in nipreps/fmriprep#1384.