Skip to content
revive

feat:support watch config_group #238

Sign in to view logs

feat:support watch config_group

feat:support watch config_group #238

Triggered via pull request November 4, 2023 00:56
@chuntaojunchuntaojun
opened #187
chuntaojun:fix_config_disaster
Status Success
Total duration 1m 12s
Artifacts –

revive.yml

on: pull_request
Matrix: Run Revive Action
Fit to window
Zoom out
Zoom in

Annotations

60 warnings
Run Revive Action (1.20.x): examples/circuitbreaker/provider/main.go#L17
should have a package comment
Run Revive Action (1.20.x): examples/watchinstance/main.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/servicerouter/filteronly/router.go#L68
parameter 'routeInfo' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.20.x): pkg/model/local/value.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/servicerouter/nearbybase/nearby.go#L95
parameter 'routeInfo' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.20.x): pkg/model/pb/metric/code.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/algorithm/hash/base.go#L32
type name will be used as hash.HashFuncWithSeed by other packages, and that stutters; consider calling this FuncWithSeed
Run Revive Action (1.20.x): plugin/servicerouter/filteronly/router.go#L68
parameter 'clusters' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.20.x): plugin/servicerouter/setdivision/setdivision.go#L69
parameter 'routeInfo' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.20.x): plugin/servicerouter/rulebase/rule.go#L78
parameter 'clusters' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.15.x): examples/circuitbreaker/provider/main.go#L17
should have a package comment
Run Revive Action (1.15.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/quickstart/provider/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/ratelimit/provider/main.go#L18
should have a package comment
Run Revive Action (1.15.x): plugin/servicerouter/canary/canary_router.go#L18
should have a package comment
Run Revive Action (1.15.x): plugin/healthcheck/http/config.go#L18
should have a package comment
Run Revive Action (1.15.x): plugin/servicerouter/filteronly/router.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/flow/detect/ticker.go#L76
parameter 'taskValue' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.19.x): examples/quickstart/provider/main.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/flow/detect/object.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/metric/bucket.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/activehealthcheck/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/flow/registerstate/register_flow.go#L41
exported function NewRegisterStateManager should have comment or be unexported
Run Revive Action (1.19.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/model/pb/validate.go#L79
func ConvertServerErrorToRpcError should be ConvertServerErrorToRPCError
Run Revive Action (1.18.x): examples/configuration/normal/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/extensions/zeroprotect/main.go#L18
should have a package comment
Run Revive Action (1.18.x): benchmark/benchmain/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/quickstart/consumer/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/circuitbreaker/provider/main.go#L17
should have a package comment
Run Revive Action (1.18.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.18.x): benchmark/benchsimple/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/route/dynamic/consumer/main.go#L18
should have a package comment
Run Revive Action (1.18.x): api_config.go#L111
comment on exported function NewConfigGroupAPIByConfig should be of the form "NewConfigGroupAPIByConfig ..."
Run Revive Action (1.17.x): pkg/flow/detect/ticker.go#L111
context.Context should be the first parameter of a function
Run Revive Action (1.17.x): pkg/flow/detect/object.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/flow/detect/ticker.go#L76
parameter 'taskValue' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.17.x): pkg/flow/registerstate/register_flow.go#L71
exported method PutRegister returns unexported type *registerstate.registerState, which can be annoying to use
Run Revive Action (1.17.x): pkg/model/local/value.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/model/pb/metric/code.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/plugin/configconnector/config_connector.go#L19
should have a package comment
Run Revive Action (1.17.x): plugin/healthcheck/http/config.go#L18
should have a package comment
Run Revive Action (1.17.x): plugin/healthcheck/tcp/config.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/model/pb/assist.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/route/dynamic/provider/main.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/watch/instance/longpull/main.go#L88
should omit type uint64 from declaration of var index; it will be inferred from the right-hand side
Run Revive Action (1.16.x): api_config.go#L111
comment on exported function NewConfigGroupAPIByConfig should be of the form "NewConfigGroupAPIByConfig ..."
Run Revive Action (1.16.x): examples/watch/service/notify/main.go#L44
exported type TestListener should have comment or be unexported
Run Revive Action (1.16.x): examples/watch/instance/notify/main.go#L76
exported type TestListener should have comment or be unexported
Run Revive Action (1.16.x): pkg/algorithm/rand/scalable_rand_test.go#L51
parameter 't' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.16.x): examples/ratelimit/provider/main.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/route/dynamic/consumer/main.go#L18
should have a package comment
Run Revive Action (1.16.x): pkg/flow/detect/object.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/watch/instance/longpull/main.go#L18
should have a package comment