Skip to content

fix:[动态配置]修复config_flow递归加读锁导致的死锁问题 (#212) #287

fix:[动态配置]修复config_flow递归加读锁导致的死锁问题 (#212)

fix:[动态配置]修复config_flow递归加读锁导致的死锁问题 (#212) #287

Triggered via push August 11, 2024 06:48
Status Success
Total duration 1m 34s
Artifacts

revive.yml

on: push
Matrix: Run Revive Action
Fit to window
Zoom out
Zoom in

Annotations

66 warnings
Run Revive Action (1.20.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.20.x): test/tools/tools_vet.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/weightadjuster/ratedelay/ratedelay.go#L58
parameter 'service' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.20.x): pkg/plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/loadbalancer/hash/config.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/plugin/metrics/proxy.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/model/pb/metric/code.go#L18
should have a package comment
Run Revive Action (1.20.x): test/common/constant.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/plugin/location/location.go#L27
exported const ProviderName should have comment (or a comment on this block) or be unexported
Run Revive Action (1.20.x): pkg/plugin/weightadjuster/proxy.go#L18
should have a package comment
Run Revive Action (1.19.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.19.x): plugin/loadbalancer/weightedrandom/wr.go#L65
parameter 'ignoreHalfOpen' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.19.x): plugin/location/local/local.go#L36
exported function New should have comment or be unexported
Run Revive Action (1.19.x): plugin/loadbalancer/weightedrandom/wr.go#L18
should have a package comment
Run Revive Action (1.19.x): plugin/servicerouter/filteronly/router.go#L68
parameter 'routeInfo' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.19.x): plugin/location/local/local.go#L18
should have a package comment
Run Revive Action (1.19.x): plugin/servicerouter/filteronly/router.go#L18
should have a package comment
Run Revive Action (1.19.x): plugin/servicerouter/filteronly/router.go#L68
parameter 'clusters' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.19.x): test/common/constant.go#L41
exported var ServerSwitchSuitServerPort should have comment or be unexported
Run Revive Action (1.19.x): test/common/constant.go#L21
exported const ConsumerSuitServerPort should have comment (or a comment on this block) or be unexported
Run Revive Action (1.19.x): test/tools/tools_vet.go#L18
should have a package comment
Run Revive Action (1.17.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.17.x): examples/circuitbreaker/interface/consumer/main.go#L75
parameter 'ctx' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.17.x): examples/circuitbreaker/interface/provider/main.go#L72
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.17.x): examples/circuitbreaker/interface/consumer/main.go#L95
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.17.x): api.go#L134
exported type GetConfigFileRequest should have comment or be unexported
Run Revive Action (1.17.x): api/circuitbreaker.go#L38
exported type ResultToErrorCode should have comment or be unexported
Run Revive Action (1.17.x): examples/route/dynamic/provider/main.go#L123
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.17.x): examples/watch/instance/notify/main.go#L76
exported type TestListener should have comment or be unexported
Run Revive Action (1.17.x): plugin/metrics/common/container.go#L23
exported type MarkedContainer should have comment or be unexported
Run Revive Action (1.17.x): pkg/log/default.go#L23
exported const DefaultLogLevel should have comment (or a comment on this block) or be unexported
Run Revive Action (1.17.x): pkg/flow/registerstate/register_flow.go#L41
exported function NewRegisterStateManager should have comment or be unexported
Run Revive Action (1.18.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.18.x): examples/activehealthcheck/main.go#L129
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): benchmark/benchmain/main.go#L46
const operationRpcDirect should be operationRPCDirect
Run Revive Action (1.18.x): examples/circuitbreaker/instance/consumer/main.go#L100
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.18.x): benchmark/benchmain/main.go#L47
const operationRpcNaming should be operationRPCNaming
Run Revive Action (1.18.x): examples/quickstart/provider/main.go#L73
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): examples/quickstart/consumer/main.go#L74
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): examples/route/nearby/provider/main.go#L132
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): examples/route/dynamic/provider/main.go#L123
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): pkg/algorithm/rand/scalable_rand_test.go#L51
parameter 't' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.15.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.15.x): benchmark/benchsimple/main.go#L71
var maxQps should be maxQPS
Run Revive Action (1.15.x): benchmark/benchsimple/main.go#L239
func runQpsLimitFeature should be runQPSLimitFeature
Run Revive Action (1.15.x): benchmark/benchsimple/main.go#L181
struct field maxQps should be maxQPS
Run Revive Action (1.15.x): api_config.go#L116
comment on exported function NewConfigGroupAPIByConfig should be of the form "NewConfigGroupAPIByConfig ..."
Run Revive Action (1.15.x): benchmark/benchsimple/main.go#L414
var useQpsLimit should be useQPSLimit
Run Revive Action (1.15.x): api_config.go#L138
comment on exported function NewConfigGroupAPIByContext should be of the form "NewConfigGroupAPIByContext ..."
Run Revive Action (1.15.x): api_config.go#L127
comment on exported function NewConfigGroupAPIByFile should be of the form "NewConfigGroupAPIByFile ..."
Run Revive Action (1.15.x): benchmark/benchmain/main.go#L47
const operationRpcNaming should be operationRPCNaming
Run Revive Action (1.15.x): benchmark/benchmain/main.go#L46
const operationRpcDirect should be operationRPCDirect
Run Revive Action (1.15.x): api.go#L162
exported type CircuitBreakerAPI should have comment or be unexported
Run Revive Action (1.16.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.16.x): benchmark/benchsimple/main.go#L89
comment on exported type Durations should be of the form "Durations ..." (with optional leading article)
Run Revive Action (1.16.x): api_config.go#L116
comment on exported function NewConfigGroupAPIByConfig should be of the form "NewConfigGroupAPIByConfig ..."
Run Revive Action (1.16.x): pkg/plugin/configfilter/configfilter.go#L19
should have a package comment
Run Revive Action (1.16.x): api_config.go#L138
comment on exported function NewConfigGroupAPIByContext should be of the form "NewConfigGroupAPIByContext ..."
Run Revive Action (1.16.x): api_config.go#L127
comment on exported function NewConfigGroupAPIByFile should be of the form "NewConfigGroupAPIByFile ..."
Run Revive Action (1.16.x): plugin/location/local/local.go#L36
exported function New should have comment or be unexported
Run Revive Action (1.16.x): plugin/location/location.go#L35
type name will be used as location.LocationPlugin by other packages, and that stutters; consider calling this Plugin
Run Revive Action (1.16.x): plugin/location/remoteservice/remoteservice.go#L35
exported function New should have comment or be unexported
Run Revive Action (1.16.x): plugin/location/remotehttp/remotehttp.go#L33
exported function New should have comment or be unexported
Run Revive Action (1.16.x): pkg/stat/plugin/plug.go#L29
type name will be used as plugin.PluginAPI by other packages, and that stutters; consider calling this API