Skip to content
revive

fix:修复demo配置不正确问题 #284

Sign in to view logs

fix:修复demo配置不正确问题

fix:修复demo配置不正确问题 #284

Triggered via pull request July 19, 2024 13:58
@chuntaojunchuntaojun
opened #211
chuntaojun:fix/ratelimit_rule
Status Success
Total duration 51s
Artifacts –

revive.yml

on: pull_request
Matrix: Run Revive Action
Fit to window
Zoom out
Zoom in

Annotations

66 warnings
Run Revive Action (1.16.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.16.x): pkg/plugin/common/plugin.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.16.x): pkg/plugin/loadbalancer/loadbalancer.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.16.x): pkg/clock/clock.go#L77
exported function CurrentMillis should have comment or be unexported
Run Revive Action (1.16.x): pkg/plugin/metrics/proxy.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/watch/service/notify/main.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.16.x): pkg/model/pb/metric/v2/code.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/watch/service/notify/main.go#L44
exported type TestListener should have comment or be unexported
Run Revive Action (1.17.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.17.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.17.x): examples/configuration/normal/main.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/stat/loadbalance/lb.go#L18
should have a package comment
Run Revive Action (1.17.x): plugin/weightadjuster/ratedelay/ratedelay.go#L58
parameter 'service' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.17.x): plugin/healthcheck/utils/detection_utils_test.go#L25
should not use dot imports
Run Revive Action (1.17.x): plugin/location/local/local.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/plugin/common/plugin.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/plugin/circuitbreaker/circuitbreaker.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/plugin/configconnector/config_connector.go#L19
should have a package comment
Run Revive Action (1.18.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.18.x): examples/configuration/normal/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.18.x): plugin/loadbalancer/common/half_open.go#L18
should have a package comment
Run Revive Action (1.18.x): pkg/stat/loadbalance/lb.go#L27
type name will be used as loadbalance.LoadBalanceGauge by other packages, and that stutters; consider calling this Gauge
Run Revive Action (1.18.x): pkg/plugin/weightadjuster/proxy.go#L18
should have a package comment
Run Revive Action (1.18.x): pkg/stat/plugin/plug.go#L29
type name will be used as plugin.PluginAPI by other packages, and that stutters; consider calling this API
Run Revive Action (1.18.x): plugin/location/location.go#L35
type name will be used as location.LocationPlugin by other packages, and that stutters; consider calling this Plugin
Run Revive Action (1.18.x): pkg/model/pb/metric/v2/code.go#L22
exported type Code should have comment or be unexported
Run Revive Action (1.18.x): plugin/location/local/local.go#L36
exported function New should have comment or be unexported
Run Revive Action (1.18.x): pkg/stat/loadbalance/lb.go#L18
should have a package comment
Run Revive Action (1.19.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.19.x): examples/circuitbreaker/instance/consumer/main.go#L100
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.19.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.19.x): examples/quickstart/consumer/main.go#L74
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.19.x): examples/configuration/normal/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/circuitbreaker/instance/provider/main.go#L73
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.19.x): examples/quickstart/provider/main.go#L73
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.19.x): benchmark/benchmain/main.go#L325
parameter 'pos' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.19.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/route/nearby/consumer/main.go#L73
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.19.x): examples/activehealthcheck/main.go#L129
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.15.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.15.x): benchmark/benchmain/main.go#L325
parameter 'ctx' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.15.x): benchmark/benchmain/main.go#L325
parameter 'pos' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.15.x): benchmark/benchmain/main.go#L47
const operationRpcNaming should be operationRPCNaming
Run Revive Action (1.15.x): benchmark/benchmain/main.go#L46
const operationRpcDirect should be operationRPCDirect
Run Revive Action (1.15.x): examples/activehealthcheck/main.go#L129
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.15.x): benchmark/benchsimple/main.go#L71
var maxQps should be maxQPS
Run Revive Action (1.15.x): examples/circuitbreaker/instance/provider/main.go#L73
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.15.x): pkg/plugin/ratelimiter/model.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/circuitbreaker/interface/consumer/main.go#L75
parameter 'ctx' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.15.x): pkg/plugin/weightadjuster/proxy.go#L18
should have a package comment
Run Revive Action (1.20.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.20.x): pkg/plugin/location/proxy.go#L26
exported type Proxy should have comment or be unexported
Run Revive Action (1.20.x): pkg/plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.20.x): examples/configuration/normal/main.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/plugin/ratelimiter/model.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/stat/loadbalance/lb.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/stat/plugin/plug.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/watchinstance/main.go#L18
should have a package comment