Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix the verify_dict_indices codegen #20920

Merged

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Jan 26, 2025

I did some more tests and found out the problem for the codegen problem here.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jan 26, 2025
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.76%. Comparing base (aa1b45f) to head (c8daec8).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
...c/arrow/read/deserialize/dictionary_encoded/mod.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20920      +/-   ##
==========================================
+ Coverage   79.64%   79.76%   +0.12%     
==========================================
  Files        1571     1569       -2     
  Lines      223185   222746     -439     
  Branches     2554     2574      +20     
==========================================
- Hits       177749   177668      -81     
+ Misses      44851    44487     -364     
- Partials      585      591       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite merged commit 14c673e into pola-rs:main Jan 26, 2025
24 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants