Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Move sum kernel to polars-compute #20867

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 23, 2025

This was the last bit of machinery that relied on the old Simd trait ecosystem in polars-arrow, so I could remove that. We also lost a dependency on multiversion. We might have to re-evaluate dynamic dispatch to AVX512 (which was the only thing multiversion was doing as we're compiling with AVX2 by default) for the sum kernels at a later point.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jan 23, 2025
@ritchie46
Copy link
Member

We might have to re-evaluate dynamic dispatch to AVX512 (which was the only thing multiversion was doing as we're compiling with AVX2 by default) for the sum kernels at a later point.

I think it's fine. For Polars cloud we can compile for avx512 directly.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 79.48718% with 16 lines in your changes missing coverage. Please review.

Project coverage is 79.63%. Comparing base (79eedcf) to head (221fd6e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-compute/src/sum.rs 80.00% 14 Missing ⚠️
...pe/src/executors/sinks/group_by/aggregates/mean.rs 66.66% 1 Missing ⚠️
...ipe/src/executors/sinks/group_by/aggregates/sum.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20867      +/-   ##
==========================================
- Coverage   79.64%   79.63%   -0.01%     
==========================================
  Files        1571     1567       -4     
  Lines      223186   223037     -149     
  Branches     2554     2554              
==========================================
- Hits       177751   177615     -136     
+ Misses      44850    44837      -13     
  Partials      585      585              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit a4cf96f into pola-rs:main Jan 23, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants