Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect Decimal value for fill_null(strategy="one") #20844

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

lukemanley
Copy link
Contributor

Fixes the following:

from decimal import Decimal
import polars as pl

ser = pl.Series([Decimal("1.23"), None])
ser.fill_null(strategy="one")

BEFORE:

shape: (2,)
Series: '' [decimal[*,2]]
[
        1.23
        0.01
]

AFTER:

shape: (2,)
Series: '' [decimal[*,2]]
[
        1.23
        1.00
]

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.63%. Comparing base (9c1637c) to head (93bb046).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20844      +/-   ##
==========================================
- Coverage   79.63%   79.63%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      223146   223153       +7     
  Branches     2546     2546              
==========================================
- Hits       177711   177710       -1     
- Misses      44851    44859       +8     
  Partials      584      584              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 24fccc4 into pola-rs:main Jan 22, 2025
24 of 27 checks passed
@lukemanley lukemanley deleted the fill-null-decimal branch January 23, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants