Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raise error instead of panicking with struct inside .over() #20836

Closed
wants to merge 2 commits into from

Conversation

etiennebacher
Copy link
Contributor

Fixes #20688

I don't know how to implement this (or even if you'd want that), but at least it doesn't panic anymore.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 21, 2025
@etiennebacher
Copy link
Contributor Author

etiennebacher commented Jan 21, 2025

Error is unrelated, this URL in the user guide is 404: https://theunitedstates.io/congress-legislators/legislators-historical.csv

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.70%. Comparing base (099ee3c) to head (7371cc2).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20836      +/-   ##
==========================================
+ Coverage   79.63%   79.70%   +0.06%     
==========================================
  Files        1568     1569       +1     
  Lines      222970   223014      +44     
  Branches     2544     2546       +2     
==========================================
+ Hits       177555   177746     +191     
+ Misses      44831    44684     -147     
  Partials      584      584              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

struct inside .over() PanicException
2 participants