Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix typo in custom expressions docs #19292

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

laurentS
Copy link
Contributor

@laurentS laurentS commented Oct 17, 2024

This PR fixes a typo introduced in #14621.
The comments in that PR correctly mention teaching about using abi3-py38 but the actual docs missed a 3, leading to beginners like me to struggle with what is happening 😅

The specific error when running maturin develop was:

error: failed to select a version for `pyo3-polars`. 

The change above seems to have resolved the problem.

@laurentS laurentS changed the title Fix typo in custom expressions docs docs: Fix typo in custom expressions docs Oct 17, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Oct 17, 2024
Copy link
Collaborator

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@ritchie46 ritchie46 merged commit 20cbe8d into pola-rs:main Oct 18, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants