Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing infer_schema for DataType::Null #19201

Merged
merged 5 commits into from
Oct 13, 2024
Merged

fix: Fixing infer_schema for DataType::Null #19201

merged 5 commits into from
Oct 13, 2024

Conversation

Bidek56
Copy link
Contributor

@Bidek56 Bidek56 commented Oct 11, 2024

Fixing infer_schema for DataType::Null to close #19184 and fix #256 from nodejs-polars

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (48f6e9d) to head (d2d23a8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19201      +/-   ##
==========================================
+ Coverage   79.65%   79.67%   +0.02%     
==========================================
  Files        1532     1532              
  Lines      209101   209097       -4     
  Branches     2417     2417              
==========================================
+ Hits       166557   166607      +50     
+ Misses      41998    41944      -54     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b481597 into pola-rs:main Oct 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

infer_schema for DataType::Null readRecords should not discard null values
2 participants