feat: Centralise acquisition of "POLARS_TEMP_DIR", and add set_temp_dir to the Config object
#18063
+116
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
c-peters,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18063 +/- ##
==========================================
- Coverage 80.35% 80.33% -0.02%
==========================================
Files 1496 1496
Lines 197685 197691 +6
Branches 2821 2823 +2
==========================================
- Hits 158845 158816 -29
- Misses 38319 38354 +35
Partials 521 521 ☔ View full report in Codecov by Sentry. |
|
Found two different places where "POLARS_TEMP_DIR" is established on the Rust side, so I'm going to tweak this PR a little. Will park in |
alexander-beedie
force-pushed
the
cfg-temp-dir
branch
4 times, most recently
from
213d1f3 to
d48afc5
Compare
alexander-beedie
changed the title
set_temp_dir to the Config objectset_temp_dir to the Config object
alexander-beedie
changed the title
set_temp_dir to the Config objectset_temp_dir to the Config object
alexander-beedie
force-pushed
the
cfg-temp-dir
branch
5 times, most recently
from
7ce0ed8 to
5751c75
Compare
alexander-beedie
force-pushed
the
cfg-temp-dir
branch
from
5751c75 to
26f826a
Compare
…dir` to the `Config` object
alexander-beedie
force-pushed
the
cfg-temp-dir
branch
from
26f826a to
8dcc968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the
Configobject to set the "POLARS_TEMP_DIR" env var.