make no expr the default for now

pola-rs · Jan 23, 2025 · c1f42e1 · c1f42e1
1 parent 2d8528f
commit c1f42e1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/crates/polars-io/src/parquet/read/read_impl.rs b/crates/polars-io/src/parquet/read/read_impl.rs
@@ -297,7 +297,7 @@ fn rg_to_dfs_prefiltered(
         }
     }
 
-    let do_parquet_expr = std::env::var("POLARS_NO_PARQUET_EXPR").as_deref() != Ok("1")
+    let do_parquet_expr = std::env::var("POLARS_PARQUET_EXPR").as_deref() == Ok("1")
         && live_columns.len() == 1 // Only do it with one column for now
         && hive_partition_columns.is_none_or(|hc| {
             !hc.iter()

diff --git a/crates/polars-parquet/src/arrow/read/deserialize/binview/predicate.rs b/crates/polars-parquet/src/arrow/read/deserialize/binview/predicate.rs
@@ -1,8 +1,11 @@
+//! Specialized kernels to do predicate evaluation directly on the `BinView` Parquet data.
+
 use arrow::array::View;
 use arrow::bitmap::MutableBitmap;
 
 use crate::parquet::error::ParquetResult;
 
+/// Create a mask for when a value is equal to the `needle`.
 pub fn decode_equals(
     num_expected_values: usize,
     values: &[u8],
@@ -16,6 +19,7 @@ pub fn decode_equals(
     }
 }
 
+/// Equality kernel for when the `needle` is inlineable into the `View`.
 fn decode_equals_inlinable(
     num_expected_values: usize,
     mut values: &[u8],
@@ -55,6 +59,7 @@ fn decode_equals_inlinable(
     Ok(())
 }
 
+/// Equality kernel for when the `needle` is not-inlineable into the `View`.
 fn decode_equals_non_inlineable(
     num_expected_values: usize,
     mut values: &[u8],