Rewrite all as toplevel funcs #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Jan 22, 2024
Comment on lines
+10
to
+23
| @pl.api.register_expr_namespace("xdt") | ||
| class ExprXDTNamespace: | ||
| """eXtra stuff for DateTimes.""" | ||
|
|
||
| def __init__(self, expr: pl.Expr) -> None: | ||
| self._expr = expr | ||
|
|
||
| def __getattr__(self, function_name: str) -> Callable[[Any], pl.Expr]: | ||
| def func(*args: Any, **kwargs: Any) -> pl.Expr: | ||
| return getattr(functions, function_name)( | ||
| self._expr, *args, **kwargs | ||
| ) | ||
|
|
||
| return func |
There was a problem hiding this comment.
adding this for backwards-compatibility, so that
from datetime import date
import polars as pl
import polars_xdt # noqa: F401
df = pl.DataFrame(
{"date": [date(2023, 4, 3), date(2023, 9, 1), date(2024, 1, 4)]}
)
result = df.with_columns(
date_shifted=pl.col("date").xdt.offset_by(
'5bd',
weekend=('Sat', 'Sun'),
)
)
print(result)can still run
Not that there's many (any?) real users yet, but still, being backwards compatible is a good practice
MarcoGorelli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would address the type checking issues reported in pola-rs/polars#13899
But it keeps the namespace
pl.col('a').xdtsyntax available for anyone who prefers itTODO: fix some argument names and type annotations