Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Genesis files #32

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated Genesis files #32

wants to merge 2 commits into from

Conversation

jorgecuesta
Copy link
Collaborator

Summary

Update genesis files from: https://github.com/pokt-network/pocket-net…work-genesis/tree/master/shannon

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@jorgecuesta jorgecuesta added the enhancement New feature or request label Nov 22, 2024
@jorgecuesta jorgecuesta self-assigned this Nov 22, 2024
@@ -1,6 +1,6 @@
FROM node:22.5-slim AS builder

ARG GENESIS_FILENAME=testnet.json
ARG GENESIS_FILENAME=localnet.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is my recollection correct that this effectively changes the default genesis that indexer node will use?
  2. Am I understanding correctly that this means that we would be switching that default from testnet to localnet, and if so, why?

Is there a reason that the default SHOULD NOT be the current testnet? That seems like the most reasonable default to me because it does not require the user to be running localnet to start using the indexer. Do you see it differently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants