Parameter JSON serialization must be deterministic #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for a regression introduced by Per-chain RTTM (#1580). When we store a map-type parameter, we use `Codec.MarshalJSON` that doen't guarantee the order of fields in a map. This causes consensus failure because a different order of fields in the parameter store generates a different merkle tree (= AppHash). The proposed fix is to canonicalize the marshaled bytes by calling `MustSortJSON` before storing it in the tree.
Olshansk
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
@msmania LGTM and we can merge it as is.
In a followup PR, can we also tend to
-
Fixing this: https://github.com/pokt-network/pocket-core/blob/staging/x/gov/keeper/subspace.go#L216
-
Migrating the recovery guide to docs: https://www.notion.so/Recovery-guide-641ec21aead74cae806166f5f9e61394
msmania
added a commit
that referenced
this pull request
Oct 2, 2024
Due to a consensus breaking change to fix a regression in RC-0.11.1 (#1614), this patch is upgrading the protocol version to RC-0.12.0. That regression caused the chainhalt in the testnet at height block. We're rolling back the testnet to recover it. This version bump helps to make sure all validators are runing the latest version. reviewpad:summary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a regression introduced by Per-chain RTTM (#1580). When we store a map-type parameter, we use
Codec.MarshalJSONthat doen't guarantee the order of fields in a map. This causes consensus failure because a different order of fields in the parameter store generates a different merkle tree (= AppHash), resulting in chainhalt.The proposed fix is to canonicalize the marshaled bytes by calling
MustSortJSONbefore storing it in the tree.Changing
Subspace.Setis enough and a change inSubspace.SetWithSubkeywon't be necessary because it's not used from anywhere, but we should keep consistency.reviewpad:summary