This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Benchmarking and QoS Endpoint Enhancements #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue
#22
Description
Previously Grove would expose error logs in a postgres database that Poktscan would parse and index, but this has been deprecated and node operators struggle with visibility.
This PR adds a new endpoint
/qosnodes
which returns the state of QoS nodes with redacted information. This endpoint can be used to expose to node operators. Ultimately this allows node operators to determine why they aren't healthy or misconfigurated which overall improves the state of the network.Additionally, this PR adds in additional timeout errors that node operators return after post benchmarking, and adds the benchmarking results.
Other misc changes:
Type of change
Please delete option that is not relevant.
Related PRs
List related PRs below