Fix: Add test to identify misssing env vars #65

ricantar · 2023-03-10T06:54:26Z

No description provided.

height · 2023-03-10T06:54:28Z

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

ricantar · 2023-03-10T06:55:39Z

cmd/options.go

@@ -27,7 +27,7 @@ type options struct {

 func GatherInfluxOptions() db.InfluxDBOptions {
 	return db.InfluxDBOptions{
-		URL:                 environment.MustGetString(INFLUXDB_URL),
+		URL:                 environment.GetString(INFLUXDB_URL, ""),


We changed that from Must to GetString because otherwise it would panic and won't log + close the program

add test to detect missing vars

8183888

ricantar requested a review from adshmh as a code owner March 10, 2023 06:54

ricantar commented Mar 10, 2023

View reviewed changes

remove env test

9f010fb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Add test to identify misssing env vars #65

Fix: Add test to identify misssing env vars #65

ricantar commented Mar 10, 2023

height bot commented Mar 10, 2023

ricantar Mar 10, 2023

Fix: Add test to identify misssing env vars #65

Are you sure you want to change the base?

Fix: Add test to identify misssing env vars #65

Conversation

ricantar commented Mar 10, 2023

height bot commented Mar 10, 2023

ricantar Mar 10, 2023

Choose a reason for hiding this comment