Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove refs to old plans #675

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Remove refs to old plans #675

merged 8 commits into from
Sep 17, 2024

Conversation

commoddity
Copy link
Contributor

@commoddity commoddity commented Sep 12, 2024

Overview

closes #673

This PR removes all references to old plan types, as well as updates the README.md with more detail on the deployment process.

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pocket-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 3:33pm

@commoddity commoddity self-assigned this Sep 12, 2024
@commoddity commoddity added the enhancement New feature or request label Sep 12, 2024
Copy link
Contributor

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@commoddity Confirming that new applications and upgrades still work with this change?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
app/components/AccountPlan/AccountPlan.tsx Show resolved Hide resolved
Applied suggestions but unclear what the example links should point to.

Co-authored-by: Daniel Olshansky <[email protected]>
@commoddity
Copy link
Contributor Author

commoddity commented Sep 13, 2024

Thanks for the review @Olshansk.

Just a note for you and @fredteumer that we still need to determine what to do about the failing Vercel .env action:
https://github.com/pokt-foundation/grove-portal/actions/runs/10844253152/job/30092782613

See comment here: #673 (comment)

Copy link
Contributor

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@commoddity commoddity requested a review from Olshansk September 17, 2024 15:28
@commoddity
Copy link
Contributor Author

@Olshansk made requested changes. Ready to merge when you approve.

Copy link
Contributor

@fredteumer fredteumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. let's see if this resolves the CI issue with our friend Vercel

@fredteumer fredteumer merged commit 1ddef11 into stage Sep 17, 2024
5 checks passed
@fredteumer fredteumer deleted the remove-refs-to-old-plans branch September 17, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants