Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed bug in auth0 sign up when signing up with brand new user u… #552

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

commoddity
Copy link
Contributor

@commoddity commoddity commented Dec 6, 2023

Fixes the issue where signing up with a brand new Google sign in user would result in an empty user in the app state.

Overview

A short description of the changes included in your pull request.

@commoddity commoddity requested a review from kutoft December 6, 2023 23:14
Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pocket-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 11:27pm

@commoddity commoddity force-pushed the fix-bug-in-auth0-sign-up branch from b5a3b67 to c9906b2 Compare December 6, 2023 23:25
Copy link

github-actions bot commented Dec 6, 2023

Coverage Summary

Status Category Percentage Covered / Total
🟢 Lines 72.97% / 50% 3089 / 4233
🟢 Statements 72.97% / 50% 3089 / 4233
🔴 Functions 15.89% / 50% 24 / 151
🟢 Branches 90.19% / 50% 46 / 51
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
app/components/AccountPlan/AccountPlan.tsx 20.39% 100% 0% 20.39%
app/components/AccountPlan/index.ts 100% 100% 100% 100%
app/components/Identicon/Identicon.tsx 36.36% 100% 0% 36.36%
app/components/Identicon/index.ts 100% 100% 100% 100%
app/components/TitledCard/TitledCard.tsx 38.88% 100% 0% 38.88%
app/components/TitledCard/index.ts 100% 100% 100% 100%
app/hooks/useModals.tsx 20% 100% 0% 20%
app/models/portal/portal.data.ts 99.26% 100% 0% 99.26%
app/models/portal/portal.server.ts 38.46% 100% 0% 38.46%
app/models/portal/sdk.ts 95.62% 100% 13.33% 95.62%
app/models/relaymeter/relaymeter.data.ts 93.47% 100% 20% 93.47%
app/models/stripe/stripe.data.ts 99.02% 100% 0% 99.02%
app/root/portalTheme.ts 71.7% 100% 0% 71.7%
app/routes/account.$accountId.settings.plan/view.tsx 24.52% 100% 0% 24.52%
app/routes/account.$accountId.settings.plan/components/AutoScalePlanLatestInvoiceCard/AutoScalePlanLatestInvoiceCard.tsx 12.98% 100% 0% 12.98%
app/routes/account.$accountId.settings.plan/components/AutoScalePlanLatestInvoiceCard/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.settings.plan/components/AutoScalePlanOverviewCard/AutoScalePlanOverviewCard.tsx 24% 100% 0% 24%
app/routes/account.$accountId.settings.plan/components/AutoScalePlanOverviewCard/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.settings.plan/components/EnterpriseAccountOverviewCard/EnterpriseAccountOverviewCard.tsx 27.77% 100% 0% 27.77%
app/routes/account.$accountId.settings.plan/components/EnterpriseAccountOverviewCard/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.settings.plan/components/StarterAccountPlan/StarterAccountPlan.tsx 28.33% 100% 0% 28.33%
app/routes/account.$accountId.settings.plan/components/StarterAccountPlan/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.settings.plan/components/StarterPlanLimitCard/StarterPlanLimitCard.tsx 35% 100% 0% 35%
app/routes/account.$accountId.settings.plan/components/StarterPlanLimitCard/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.settings.plan/hooks/useSubscriptionModals.tsx 18.75% 100% 0% 18.75%
app/routes/user._index/view.tsx 11.62% 100% 0% 11.62%
app/styles/commonStyles.tsx 42.85% 100% 100% 42.85%
app/utils/analytics.ts 70.83% 100% 0% 70.83%
app/utils/catchError.ts 86.66% 91.66% 100% 86.66%
app/utils/dayjs.ts 87.5% 100% 0% 87.5%
app/utils/environment.server.ts 100% 100% 100% 100%
app/utils/environment.ts 100% 100% 100% 100%
app/utils/formattingUtils.ts 30% 100% 0% 30%
app/utils/identicons.ts 43.03% 100% 0% 43.03%
app/utils/planUtils.ts 34.14% 100% 0% 34.14%
app/utils/user.server.ts 53.33% 76.47% 47.36% 53.33%
app/utils/utils.ts 48.97% 100% 0% 48.97%

Copy link
Contributor

@RabeeAbuBaker RabeeAbuBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested locally and on staging, seems to be solving the issue 👌

@RabeeAbuBaker RabeeAbuBaker merged commit 1b56400 into stage Dec 7, 2023
4 checks passed
@RabeeAbuBaker RabeeAbuBaker deleted the fix-bug-in-auth0-sign-up branch December 7, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants