Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New navigation layout #534

Merged
merged 40 commits into from
Nov 14, 2023
Merged

New navigation layout #534

merged 40 commits into from
Nov 14, 2023

Conversation

RabeeAbuBaker
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pocket-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 4:24pm

Copy link

github-actions bot commented Oct 31, 2023

Coverage Summary

Status Category Percentage Covered / Total
🟢 Lines 72.01% / 50% 3081 / 4278
🟢 Statements 72.01% / 50% 3081 / 4278
🔴 Functions 16.55% / 50% 24 / 145
🟢 Branches 90.19% / 50% 46 / 51
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
app/components/AccountPlan/AccountPlan.tsx 20.39% 100% 0% 20.39%
app/components/AccountPlan/index.ts 100% 100% 100% 100%
app/components/Identicon/Identicon.tsx 36.36% 100% 0% 36.36%
app/components/Identicon/index.ts 100% 100% 100% 100%
app/components/TitledCard/TitledCard.tsx 38.88% 100% 0% 38.88%
app/components/TitledCard/index.ts 100% 100% 100% 100%
app/hooks/useModals.tsx 20% 100% 0% 20%
app/models/portal/portal.data.ts 99.26% 100% 0% 99.26%
app/models/portal/portal.server.ts 38.46% 100% 0% 38.46%
app/models/portal/sdk.ts 95.62% 100% 13.33% 95.62%
app/models/relaymeter/relaymeter.data.ts 93.47% 100% 20% 93.47%
app/models/stripe/stripe.data.ts 99.02% 100% 0% 99.02%
app/root/portalTheme.ts 71.7% 100% 0% 71.7%
app/routes/account.$accountId.settings.plan/view.tsx 17.24% 100% 0% 17.24%
app/routes/account.$accountId.settings.plan/components/AutoScalePlanLatestInvoiceCard/AutoScalePlanLatestInvoiceCard.tsx 13.6% 100% 0% 13.6%
app/routes/account.$accountId.settings.plan/components/AutoScalePlanLatestInvoiceCard/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.settings.plan/components/AutoScalePlanOverviewCard/AutoScalePlanOverviewCard.tsx 21.64% 100% 0% 21.64%
app/routes/account.$accountId.settings.plan/components/AutoScalePlanOverviewCard/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.settings.plan/components/EnterpriseAccountOverviewCard/EnterpriseAccountOverviewCard.tsx 26.41% 100% 0% 26.41%
app/routes/account.$accountId.settings.plan/components/EnterpriseAccountOverviewCard/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.settings.plan/components/StarterAccountPlan/StarterAccountPlan.tsx 28.33% 100% 0% 28.33%
app/routes/account.$accountId.settings.plan/components/StarterAccountPlan/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.settings.plan/components/StarterPlanLimitCard/StarterPlanLimitCard.tsx 35% 100% 0% 35%
app/routes/account.$accountId.settings.plan/components/StarterPlanLimitCard/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.settings.plan/hooks/useSubscriptionModals.tsx 10.97% 100% 0% 10.97%
app/routes/user.profile/view.tsx 11.62% 100% 0% 11.62%
app/styles/commonStyles.tsx 42.85% 100% 100% 42.85%
app/utils/analytics.ts 70.83% 100% 0% 70.83%
app/utils/catchError.ts 86.66% 91.66% 100% 86.66%
app/utils/dayjs.ts 87.5% 100% 0% 87.5%
app/utils/environment.server.ts 100% 100% 100% 100%
app/utils/environment.ts 100% 100% 100% 100%
app/utils/identicons.ts 43.03% 100% 0% 43.03%
app/utils/planUtils.ts 34.14% 100% 0% 34.14%
app/utils/user.server.ts 55.17% 76.47% 47.36% 55.17%
app/utils/utils.ts 52.38% 100% 0% 52.38%

…ationSubscription component and cleaning up app routes
- Adding account name to email + notification if it's available
… with latest PUB changes

- Fetching relays for each account app from relay meter
- Updating analytics utils
- Removing and cleaning up old routes/components
Copy link

gitguardian bot commented Nov 14, 2023

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8727965 Generic High Entropy Secret 208c6d1 app/models/portal/portal.data.ts View secret
8727965 Generic High Entropy Secret 26d68fb app/models/portal/portal.data.ts View secret
8727966 Generic High Entropy Secret 208c6d1 app/models/portal/portal.data.ts View secret
8727966 Generic High Entropy Secret 26d68fb app/models/portal/portal.data.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@RabeeAbuBaker RabeeAbuBaker merged commit e49a001 into stage Nov 14, 2023
4 checks passed
@RabeeAbuBaker RabeeAbuBaker deleted the new-nav branch November 14, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants