Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chart UTC #517

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Fix chart UTC #517

merged 4 commits into from
Oct 16, 2023

Conversation

kutoft
Copy link
Contributor

@kutoft kutoft commented Oct 13, 2023

Overview

  • chart data currently has an issue mixing up local time with UTC time
  • update api call to always use UTC time
  • always call for data from the start of the day instead of the current time
  • update call to get data from the previous day and back since we dont have data for the current day
  • update tsconfig to ignore the sdk folder and stop it from always changing the generated files

@kutoft kutoft requested a review from RabeeAbuBaker October 13, 2023 14:57
@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pocket-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 4:48pm

@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Coverage Summary

Status Category Percentage Covered / Total
🟢 Lines 76.21% / 50% 3724 / 4886
🟢 Statements 76.21% / 50% 3724 / 4886
🔴 Functions 14.19% / 50% 22 / 155
🟢 Branches 90.38% / 50% 47 / 52
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
app/components/AccountPlan/AccountPlan.tsx 20.39% 100% 0% 20.39%
app/components/AccountPlan/index.ts 100% 100% 100% 100%
app/components/Identicon/Identicon.tsx 36.36% 100% 0% 36.36%
app/components/Identicon/index.ts 100% 100% 100% 100%
app/components/TitledCard/TitledCard.tsx 38.88% 100% 0% 38.88%
app/components/TitledCard/index.ts 100% 100% 100% 100%
app/hooks/useModals.tsx 20.37% 100% 0% 20.37%
app/models/portal/portal.data.ts 99.14% 100% 0% 99.14%
app/models/portal/portal.server.ts 38.46% 100% 0% 38.46%
app/models/portal/sdk.ts 96.07% 100% 7.31% 96.07%
app/models/relaymeter/relaymeter.data.ts 90.69% 100% 0% 90.69%
app/models/stripe/stripe.data.ts 99.02% 100% 0% 99.02%
app/root/portalTheme.ts 71.7% 100% 0% 71.7%
app/routes/account.$accountId.$appId.plan/view.tsx 22.58% 100% 0% 22.58%
app/routes/account.$accountId.$appId.plan/components/AppEnterpriseOverviewCard/AppEnterpriseOverviewCard.tsx 26.41% 100% 0% 26.41%
app/routes/account.$accountId.$appId.plan/components/AppEnterpriseOverviewCard/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.$appId.plan/components/AppPlanLatestInvoiceCard/AppPlanLatestInvoiceCard.tsx 18.81% 100% 0% 18.81%
app/routes/account.$accountId.$appId.plan/components/AppPlanLatestInvoiceCard/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.$appId.plan/components/AppPlanOverviewCard/AppPlanOverviewCard.tsx 18.18% 100% 0% 18.18%
app/routes/account.$accountId.$appId.plan/components/AppPlanOverviewCard/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.$appId.plan/components/FreeAppPlan/FreeAppPlan.tsx 27.41% 100% 0% 27.41%
app/routes/account.$accountId.$appId.plan/components/FreeAppPlan/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.$appId.plan/components/PlanLimitOverviewCard/PlanLimitOverviewCard.tsx 35% 100% 0% 35%
app/routes/account.$accountId.$appId.plan/components/PlanLimitOverviewCard/index.ts 100% 100% 100% 100%
app/routes/account.$accountId.$appId/hooks/useSubscriptionModals.tsx 10.71% 100% 0% 10.71%
app/routes/user.profile/view.tsx 11.62% 100% 0% 11.62%
app/styles/commonStyles.tsx 42.85% 100% 100% 42.85%
app/utils/analytics.ts 70% 100% 0% 70%
app/utils/catchError.ts 86.66% 91.66% 100% 86.66%
app/utils/dayjs.ts 100% 100% 0% 100%
app/utils/environment.server.ts 100% 100% 100% 100%
app/utils/environment.ts 100% 100% 100% 100%
app/utils/identicons.ts 43.03% 100% 0% 43.03%
app/utils/planUtils.ts 34.14% 100% 0% 34.14%
app/utils/user.server.ts 56.14% 76.47% 47.36% 56.14%
app/utils/utils.ts 52.38% 100% 0% 52.38%

Copy link
Contributor

@RabeeAbuBaker RabeeAbuBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@RabeeAbuBaker RabeeAbuBaker merged commit d0dde38 into stage Oct 16, 2023
@RabeeAbuBaker RabeeAbuBaker deleted the fix-chart-utc branch October 16, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants