Don't call ErrorAndDisconnect in a goroutine

ErrorAndDisconnect can only be called in a handler as it panics with http.ErrAbortHandler which normally gets recovered by net/http.
poki · Sep 11, 2023 · a19e721 · a19e721
1 parent 4a4b93a
commit a19e721
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/signaling/handler.go b/internal/signaling/handler.go
@@ -77,8 +77,8 @@ func Handler(ctx context.Context, store stores.Store, cloudflare *cloudflare.Cre
 			for {
 				select {
 				case <-ticker.C:
-					if err := peer.Send(ctx, PingPacket{Type: "ping"}); err != nil {
-						util.ErrorAndDisconnect(ctx, conn, err)
+					if err := peer.Send(ctx, PingPacket{Type: "ping"}); err != nil && !util.IsPipeError(err) {
+						logger.Error("failed to send ping packet", zap.String("peer", peer.ID), zap.Error(err))
 					}
 				case <-ctx.Done():
 					return