Skip to content

Commit

Permalink
Point Issue Reporting to xctest-dynamic-overlay repo (#185)
Browse files Browse the repository at this point in the history
* Point Issue Reporting to xctest-dynamic-overlay repo

Swift Package Manager honors redirects, but it appears to associate the
path suffix with the package name, and this conflicts with package
resolution in certain (but not all) cases.

I think we have no choice but to roll back everything to point to the
original xctest-dynamic-overlay URL and extract Issue Reporting to a
dedicated repo.

* wip
  • Loading branch information
stephencelis authored Jul 24, 2024
1 parent 0adf7cc commit b05be6e
Show file tree
Hide file tree
Showing 4 changed files with 38 additions and 38 deletions.
2 changes: 1 addition & 1 deletion Examples/Examples.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@
repositoryURL = "http://github.com/pointfreeco/swift-dependencies";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 1.3.4;
minimumVersion = 1.3.5;
};
};
DCE73E032947D063004EE92E /* XCRemoteSwiftPackageReference "swift-tagged" */ = {
Expand Down
24 changes: 12 additions & 12 deletions Package.resolved
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/pointfreeco/swift-case-paths",
"state" : {
"revision" : "031704ba0634b45e02fe875b8ddddc7f30a07f49",
"version" : "1.5.3"
"branch" : "xct-name",
"revision" : "593151ec13a564a79dc930cf57c82a67355b76c2"
}
},
{
"identity" : "swift-custom-dump",
"kind" : "remoteSourceControl",
"location" : "https://github.com/pointfreeco/swift-custom-dump",
"state" : {
"revision" : "d237304f42af07f22563aa4cc2d7e2cfb25da82e",
"version" : "1.3.1"
"branch" : "xct-name",
"revision" : "3af72bba805d9d91aecdc5c0df15d5f8b89de8de"
}
},
{
Expand All @@ -37,21 +37,21 @@
}
},
{
"identity" : "swift-issue-reporting",
"identity" : "swift-syntax",
"kind" : "remoteSourceControl",
"location" : "https://github.com/pointfreeco/swift-issue-reporting",
"location" : "https://github.com/swiftlang/swift-syntax",
"state" : {
"revision" : "926f43898706eaa127db79ac42138e1ad7e85a3f",
"version" : "1.2.0"
"revision" : "4c6cc0a3b9e8f14b3ae2307c5ccae4de6167ac2c",
"version" : "600.0.0-prerelease-2024-06-12"
}
},
{
"identity" : "swift-syntax",
"identity" : "xctest-dynamic-overlay",
"kind" : "remoteSourceControl",
"location" : "https://github.com/swiftlang/swift-syntax",
"location" : "https://github.com/pointfreeco/xctest-dynamic-overlay",
"state" : {
"revision" : "4c6cc0a3b9e8f14b3ae2307c5ccae4de6167ac2c",
"version" : "600.0.0-prerelease-2024-06-12"
"revision" : "357ca1e5dd31f613a1d43320870ebc219386a495",
"version" : "1.2.2"
}
}
],
Expand Down
10 changes: 5 additions & 5 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@ let package = Package(
],
dependencies: [
.package(url: "https://github.com/apple/swift-docc-plugin", from: "1.0.0"),
.package(url: "https://github.com/pointfreeco/swift-case-paths", from: "1.5.3"),
.package(url: "https://github.com/pointfreeco/swift-custom-dump", from: "1.3.1"),
.package(url: "https://github.com/pointfreeco/swift-issue-reporting", from: "1.2.0"),
.package(url: "https://github.com/pointfreeco/swift-case-paths", branch: "xct-name"),
.package(url: "https://github.com/pointfreeco/swift-custom-dump", branch: "xct-name"),
.package(url: "https://github.com/pointfreeco/xctest-dynamic-overlay", from: "1.2.2"),
],
targets: [
.target(
name: "SwiftUINavigation",
dependencies: [
"SwiftUINavigationCore",
.product(name: "CasePaths", package: "swift-case-paths"),
.product(name: "IssueReporting", package: "swift-issue-reporting"),
.product(name: "IssueReporting", package: "xctest-dynamic-overlay"),
]
),
.testTarget(
Expand All @@ -45,7 +45,7 @@ let package = Package(
name: "SwiftUINavigationCore",
dependencies: [
.product(name: "CustomDump", package: "swift-custom-dump"),
.product(name: "IssueReporting", package: "swift-issue-reporting"),
.product(name: "IssueReporting", package: "xctest-dynamic-overlay"),
]
),
]
Expand Down
40 changes: 20 additions & 20 deletions SwiftUINavigation.xcworkspace/xcshareddata/swiftpm/Package.resolved
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,26 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/pointfreeco/combine-schedulers",
"state" : {
"revision" : "487a4d151e795a5e076a7e7aedcd13c2ebff6c31",
"version" : "1.0.1"
"revision" : "9fa31f4403da54855f1e2aeaeff478f4f0e40b13",
"version" : "1.0.2"
}
},
{
"identity" : "swift-case-paths",
"kind" : "remoteSourceControl",
"location" : "https://github.com/pointfreeco/swift-case-paths",
"state" : {
"revision" : "031704ba0634b45e02fe875b8ddddc7f30a07f49",
"version" : "1.5.3"
"branch" : "xct-name",
"revision" : "593151ec13a564a79dc930cf57c82a67355b76c2"
}
},
{
"identity" : "swift-clocks",
"kind" : "remoteSourceControl",
"location" : "https://github.com/pointfreeco/swift-clocks",
"state" : {
"revision" : "eb64eacfed55635a771e3410f9c91de46cf5c6a0",
"version" : "1.0.3"
"revision" : "3581e280bf0d90c3fb9236fb23e75a5d8c46b533",
"version" : "1.0.4"
}
},
{
Expand All @@ -39,7 +39,7 @@
{
"identity" : "swift-concurrency-extras",
"kind" : "remoteSourceControl",
"location" : "https://github.com/pointfreeco/swift-concurrency-extras",
"location" : "https://github.com/pointfreeco/swift-concurrency-extras.git",
"state" : {
"revision" : "bb5059bde9022d69ac516803f4f227d8ac967f71",
"version" : "1.1.0"
Expand All @@ -50,17 +50,17 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/pointfreeco/swift-custom-dump",
"state" : {
"revision" : "d237304f42af07f22563aa4cc2d7e2cfb25da82e",
"version" : "1.3.1"
"branch" : "xct-name",
"revision" : "3af72bba805d9d91aecdc5c0df15d5f8b89de8de"
}
},
{
"identity" : "swift-dependencies",
"kind" : "remoteSourceControl",
"location" : "http://github.com/pointfreeco/swift-dependencies",
"state" : {
"revision" : "52018827ce21e482a36e3795bea2666b3898164c",
"version" : "1.3.4"
"revision" : "cc26d06125dbc913c6d9e8a905a5db0b994509e0",
"version" : "1.3.5"
}
},
{
Expand Down Expand Up @@ -90,15 +90,6 @@
"version" : "1.1.0"
}
},
{
"identity" : "swift-issue-reporting",
"kind" : "remoteSourceControl",
"location" : "https://github.com/pointfreeco/swift-issue-reporting",
"state" : {
"revision" : "926f43898706eaa127db79ac42138e1ad7e85a3f",
"version" : "1.2.0"
}
},
{
"identity" : "swift-syntax",
"kind" : "remoteSourceControl",
Expand All @@ -116,6 +107,15 @@
"revision" : "3907a9438f5b57d317001dc99f3f11b46882272b",
"version" : "0.10.0"
}
},
{
"identity" : "xctest-dynamic-overlay",
"kind" : "remoteSourceControl",
"location" : "https://github.com/pointfreeco/xctest-dynamic-overlay",
"state" : {
"revision" : "357ca1e5dd31f613a1d43320870ebc219386a495",
"version" : "1.2.2"
}
}
],
"version" : 2
Expand Down

0 comments on commit b05be6e

Please sign in to comment.