Optional parent node for move node #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electronicbites
force-pushed
the
optional-parent-node-for-move-node
branch
from
29fa4fe to
d81d2ea
Compare
electronicbites
force-pushed
the
optional-parent-node-for-move-node
branch
from
d81d2ea to
05984d0
Compare
in order to achieve this we need a different signature, use a keyword list instead of fixed parameters
electronicbites
force-pushed
the
optional-parent-node-for-move-node
branch
from
05984d0 to
78f21a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change the signature for
move_nodeotherwise it would not be possible to differentiate between setting a value toniland omitting the value. I used a keyword list since this a classic for optional parameters. Another option would be to use a map like forinsert_node