Feature/url extractor #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electronicbites
force-pushed
the
feature/url-extractor
branch
from
41ddc18 to
9601fc3
Compare
so we are avoiding a repository call, besides the node might have been deleted meanwhile also next id which was used for `NodeDeletedEvent` might be nil
that listens to change events of nodes
electronicbites
force-pushed
the
feature/url-extractor
branch
from
9601fc3 to
e0f3411
Compare
electronicbites
force-pushed
the
feature/url-extractor
branch
from
e0f3411 to
14cf422
Compare
|
Hey @electronicbites, regarding the topic:
when we have multiple outlines, how can we only subscribe (get updates for) the outline we are currently editing and not updates from other episode-nodes someone else is using in another episode? is this already the case or would the subscribe with episode_id be a good idea here? |
|
@sorax currently there is now way. It totally makes sense to create a channel per outline. I was about to write, we will do it later, but the more I am thinking about, I am about to revert this commit ... still thinking ;) |
sorax
approved these changes
Sep 2, 2024
|
let's merge this and do it later on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a mechanism to detect URLs in node contents. If an URL is detected it just gets logged. It should be stored as an entity to the database. The frontend could present detected URls, the content of a website could be scraped and URLs can be exported to the show notes
This PR also introduces ChangesListener that subscribes to every change in the outliner.
The
EventConsumerwas renamed toCommandProcessorepisode_id was added to every event type while it was removed from the
Dispatch.subscribefunction since it was not used.