Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect outline nodes to episodes #510

Merged
merged 7 commits into from
Jan 14, 2024

Conversation

electronicbites
Copy link
Collaborator

@electronicbites electronicbites commented Dec 16, 2023

Connect nodes to episodes. This is a required argument. No node should be be dangling since they would never be shown.

The controller expects a show_id for a node to be created. In order to connect the node the a episode we need do find a episode. In the near future this will be the one in draft mode, or even the one stored in a user preference.
Currently it just returns the episode with the highest number. And episodes have a number now.

@electronicbites electronicbites force-pushed the connect-outline-nodes-to-episodes branch 4 times, most recently from f1ed47d to 0259a74 Compare December 28, 2023 13:48
currently it is optional but it should be required
@electronicbites electronicbites force-pushed the connect-outline-nodes-to-episodes branch from 0259a74 to 0aea2f2 Compare December 28, 2023 16:25
@electronicbites electronicbites self-assigned this Dec 28, 2023
@electronicbites electronicbites marked this pull request as ready for review December 28, 2023 16:32
@electronicbites electronicbites force-pushed the connect-outline-nodes-to-episodes branch from 0aea2f2 to 72a2696 Compare January 4, 2024 19:53
@electronicbites electronicbites force-pushed the connect-outline-nodes-to-episodes branch from be065d9 to c678a14 Compare January 9, 2024 18:52
Copy link
Collaborator

@sorax sorax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@electronicbites electronicbites merged commit 787c2b1 into main Jan 14, 2024
1 check passed
@electronicbites electronicbites deleted the connect-outline-nodes-to-episodes branch January 14, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants