Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base resources #501

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add base resources #501

merged 1 commit into from
Dec 19, 2023

Conversation

electronicbites
Copy link
Collaborator

@electronicbites electronicbites commented Nov 28, 2023

Add basic resources stations, podcasts and episodes
related to #497

@electronicbites electronicbites self-assigned this Nov 28, 2023
@electronicbites electronicbites mentioned this pull request Nov 28, 2023
@electronicbites electronicbites force-pushed the add-base-resources branch 2 times, most recently from 2649142 to a19c13d Compare December 4, 2023 20:28
@electronicbites electronicbites marked this pull request as draft December 4, 2023 22:35
@electronicbites electronicbites marked this pull request as ready for review December 6, 2023 16:56
@electronicbites electronicbites requested a review from sorax December 6, 2023 17:12
lib/radiator/podcasts.ex Outdated Show resolved Hide resolved
@electronicbites electronicbites force-pushed the add-base-resources branch 3 times, most recently from dc91043 to 6c4651e Compare December 16, 2023 19:05
Copy link
Collaborator

@sorax sorax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: can we delete the views & the page_html?

@electronicbites
Copy link
Collaborator Author

question: can we delete the views & the page_html?

of course, but it was not part of my plan to include the change in this PR. I oversaw the movement. Fixed that. Since this is unrelated I will make an extra PR for this change ;)

@electronicbites
Copy link
Collaborator Author

@sorax now the PR is ready for review, thanks ;)

Copy link
Collaborator

@sorax sorax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything fine! Feel free to merge.

@electronicbites electronicbites merged commit a0ede33 into main Dec 19, 2023
1 check passed
@electronicbites electronicbites deleted the add-base-resources branch December 19, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants