fixup 2 credo

lib/radiator/outline/dispatch.ex

@@ -1,9 +1,7 @@
 defmodule Radiator.Outline.Dispatch do
   @moduledoc false
 
-  alias Radiator.Outline.Command
-  alias Radiator.Outline.Event
-  alias Radiator.Outline.EventProducer
+  alias Radiator.Outline.{Command, Event, EventProducer, Validations}
 
   def insert_node(attributes, user_id, event_id) do
     "insert_node"
@@ -34,11 +32,13 @@ defmodule Radiator.Outline.Dispatch do
   end
 
   def broadcast(event) do
-    if Mix.env == :dev || Mix.env == :test do
-      :ok = event
-      |> Event.episode_id()
-      |> Radiator.Outline.Validations.validate_tree_for_episode()
+    if Mix.env() == :dev || Mix.env() == :test do
+      :ok =
+        event
+        |> Event.episode_id()
+        |> Validations.validate_tree_for_episode()
     end
+
     Phoenix.PubSub.broadcast(Radiator.PubSub, "events", event)
   end
 

lib/radiator/outline/event.ex

@@ -9,6 +9,7 @@ defmodule Radiator.Outline.Event do
     NodeInsertedEvent,
     NodeMovedEvent
   }
+
   alias Radiator.Outline.NodeRepository
 
   def payload(%NodeInsertedEvent{} = event) do

lib/radiator/outline/validations.ex

@@ -39,11 +39,13 @@ defmodule Radiator.Outline.Validations do
     end
   end
 
+  @doc """
+  Validates a tree for an episode.
+  Returns :ok if the tree is valid
+  """
   def validate_tree_for_episode(episode_id) do
     {:ok, tree_nodes} = Outline.get_node_tree(episode_id)
-    # tree_nodes
-    # every level has 1 node with prev_id nil
-    # all other nodes in level have prev_id set and are connected to the previous node
+
     if Enum.count(tree_nodes) == NodeRepository.count_nodes_by_episode(episode_id) do
       validate_tree_nodes(tree_nodes)
     else
@@ -52,27 +54,35 @@ defmodule Radiator.Outline.Validations do
   end
 
   # iterate through the levels of the tree
+  # every level has 1 node with prev_id nil
+  # all other nodes in level have prev_id set and are connected to the previous node
+  # should be used in dev and test only
+  # might crash if the tree is not consistent
   defp validate_tree_nodes(tree_nodes) do
-    tree_nodes
-    |> Enum.group_by(& &1.level)
-    |> Enum.map(fn {_level, nodes} ->
-      # get the node with prev_id nil
-      first_node = Enum.find(nodes, &(&1.prev_id == nil))
-      # get the rest of the nodes
-      rest_nodes = Enum.reject(nodes, &(&1.prev_id == nil))
-      # iterate through the rest of the nodes
-      Enum.reduce(rest_nodes, first_node, fn node, prev_node ->
-        check_node_prev_node_of(prev_node, node)
+    _all_level_nodes =
+      tree_nodes
+      |> Enum.group_by(& &1.level)
+      |> Enum.map(fn {_level, nodes} ->
+        # get the node with prev_id nil
+        first_node = Enum.find(nodes, &(&1.prev_id == nil))
+        # get the rest of the nodes
+        rest_nodes = Enum.reject(nodes, &(&1.prev_id == nil))
+        # iterate through the rest of the nodes
+        %Node{} =
+          _last_node =
+          Enum.reduce(rest_nodes, first_node, fn node, prev_node ->
+            check_node_prev_node_of(prev_node, node)
+          end)
       end)
-    end)
+
     :ok
   end
 
   defp check_node_prev_node_of(
-        %Node{uuid: id},
-        %Node{prev_id: id} = node
-      ),
-      do: node
+         %Node{uuid: id},
+         %Node{prev_id: id} = node
+       ),
+       do: node
 
   defp check_node_prev_node_of(_, _), do: {:error, :prev_id_not_consistent}
 end