Edit campaing application task(Admin and Organaizer) #660
+391
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
slavcho
requested changes
Jul 26, 2024
| const person = await this.personService.findOneByKeycloakId(user.sub) | ||
| if (!person) throw new NotFoundException('User is not found') | ||
|
|
||
| let isAdminFlag |
There was a problem hiding this comment.
You don't need this defined before the ifs since you are not using it after that.
Try to define variables in the scope they are used.
There was a problem hiding this comment.
I was referring to the isAdminFlag, but it is not a big deal.
| organaizerId?: string, | ||
| files?: Express.Multer.File[], | ||
| ) { | ||
| console.log(id) |
| personId: string, | ||
| updateCampaignApplicationDto: UpdateCampaignApplicationDto, | ||
| isAdminFlag: boolean, | ||
| organaizerId?: string, |
Comment on lines
174
to
177
| for (const file of existingCampaignApplicationFiles) { | ||
| await this.s3.deleteObject(this.bucketName, file.id) | ||
| } | ||
|
|
There was a problem hiding this comment.
Why do we delete the previous files?
I'd say the default is that we incrementally add new files.
If the user wants to delete a file - they should do so explicitly one by one.
| @@ -1,7 +1,7 @@ | |||
| import { Person } from '@prisma/client' | |||
|
|
|||
| export const personMock: Person = { | |||
| id: 'e43348aa-be33-4c12-80bf-2adfbf8736cd', | |||
| id: 'personId', | |||
add new endpoint for uploading files to campaignApplication remove upload functionality on create and on update campaignApplication
slavcho
approved these changes
Aug 7, 2024
| const person = await this.personService.findOneByKeycloakId(user.sub) | ||
| if (!person) throw new NotFoundException('User is not found') | ||
|
|
||
| let isAdminFlag |
There was a problem hiding this comment.
I was referring to the isAdminFlag, but it is not a big deal.
github-actions
bot
removed
the
run tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.