Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made currency required in the API, cleaned up the create or connect #574

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Made currency required in the API, cleaned up the create or connect #574

merged 1 commit into from
Nov 7, 2023

Conversation

yyosifov
Copy link
Contributor

@yyosifov yyosifov commented Nov 5, 2023

  • Set the currency as required when creating a new Campaign via the API
  • Cleaned up the vault resolution logic (create or connect) - there is always a default vault created when a Campaign is created

Closes 420

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023 •
edited
Loading

✅ Tests will run for this PR. Once they succeed it can be merged.

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Nov 6, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Nov 6, 2023
igoychev
igoychev approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@igoychev igoychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Well done with ensuring there will always be a default vault when creating the campaign! findFirstOrThrow!

@igoychev igoychev merged commit fcab466 into podkrepi-bg:master Nov 7, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoychev igoychev igoychev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yyosifov @igoychev