src/donations: Remove person relation from user/:id response

Donor's names will be claimed by the session token.
podkrepi-bg · Dec 18, 2023 · 20df8af · 20df8af
1 parent 80ac1f3
commit 20df8af
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 19 deletions.
diff --git a/apps/api/src/donations/donations.controller.ts b/apps/api/src/donations/donations.controller.ts
@@ -178,13 +178,7 @@ export class DonationsController {
   @Get('user/:id')
   async userDonationById(@Param('id') id: string, @AuthenticatedUser() user: KeycloakTokenParsed) {
     const donation = await this.donationsService.getUserDonationById(id, user.sub, user.email)
-    return {
-      ...donation,
-      person: {
-        firstName: user.given_name,
-        lastName: user.family_name,
-      },
-    }
+    return donation
   }
 
   @Post('payment-intent')

diff --git a/apps/api/src/donations/donations.service.ts b/apps/api/src/donations/donations.service.ts
@@ -461,25 +461,14 @@ export class DonationsService {
     id: string,
     keycloakId: string,
     email?: string,
-  ): Promise<(Donation & { person: Person | null }) | null> {
+  ): Promise<Donation | null> {
     return await this.prisma.donation.findFirst({
       where: {
         id,
         status: DonationStatus.succeeded,
         OR: [{ billingEmail: email }, { person: { keycloakId } }],
       },
       include: {
-        person: {
-          select: {
-            id: true,
-            firstName: true,
-            lastName: true,
-            company: { select: { companyName: true } },
-          },
-        },
-        affiliate: {
-          select: { company: { select: { companyName: true } } },
-        },
         targetVault: {
           select: {
             id: true,