Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explicit error status codes for host-conf #19

Merged

Conversation

frasertweedale
Copy link
Contributor

The host-conf resource returns 404 and 409 statuses for specific semantic conditions. Add these responses codes to the response list. Distinct and specific descriptions are given to document the semantics, instead of referencing ErrorResponse with its generic description.

This minor change is mainly for documenting the API better. It does not need to be propagated to the downstream repos but can wait for whenever a more important change occurs.

The host-conf resource returns 404 and 409 statuses for specific
semantic conditions.  Add these responses codes to the response
list.  Distinct and specific descriptions are given to document the
semantics, instead of referencing ErrorResponse with its generic
description.
Copy link
Contributor

@pvoborni pvoborni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frasertweedale frasertweedale merged commit 286b935 into podengo-project:main Sep 3, 2024
1 check passed
@frasertweedale frasertweedale deleted the host-conf-error-statuses branch September 3, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants