removed the legacy BaseModel.isNew getter

pocketbase · May 1, 2023 · bde1d4c · bde1d4c
1 parent afa44ae
commit bde1d4c
Show file tree

Hide file tree

Showing 17 changed files with 17 additions and 34 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+## 0.14.4-rc
+
+- Removed the legacy aliased `BaseModel.isNew` getter since it could conflict with similarly named record fields ([pocketbase#2385](https://github.com/pocketbase/pocketbase/discussions/2385)).
+  This helper is primarly used in the Admin UI, but if you are also using in your code, it is advised to replace it with the `$` prefixed version, aka. `BaseModel.$isNew`.
+
+
 ## 0.14.3
 
 - Added `OAuth2AuthConfig.query` prop to send optional query parameters with the `authWithOAuth2(config)` call.

diff --git a/dist/pocketbase.cjs.d.ts b/dist/pocketbase.cjs.d.ts
@@ -29,10 +29,6 @@ declare abstract class BaseModel {
     $load(data: {
         [key: string]: any;
     }): void;
-    /**
-     * Alias of this.$isNew.
-     */
-    get isNew(): boolean;
     /**
      * Returns whether the current loaded data represent a stored db record.
      */

diff --git a/dist/pocketbase.cjs.js b/dist/pocketbase.cjs.js
diff --git a/dist/pocketbase.cjs.js.map b/dist/pocketbase.cjs.js.map
diff --git a/dist/pocketbase.es.d.mts b/dist/pocketbase.es.d.mts
@@ -29,10 +29,6 @@ declare abstract class BaseModel {
     $load(data: {
         [key: string]: any;
     }): void;
-    /**
-     * Alias of this.$isNew.
-     */
-    get isNew(): boolean;
     /**
      * Returns whether the current loaded data represent a stored db record.
      */

diff --git a/dist/pocketbase.es.js b/dist/pocketbase.es.js
diff --git a/dist/pocketbase.es.js.map b/dist/pocketbase.es.js.map
diff --git a/dist/pocketbase.es.mjs b/dist/pocketbase.es.mjs
diff --git a/dist/pocketbase.es.mjs.map b/dist/pocketbase.es.mjs.map
diff --git a/dist/pocketbase.iife.d.ts b/dist/pocketbase.iife.d.ts
@@ -29,10 +29,6 @@ declare abstract class BaseModel {
     $load(data: {
         [key: string]: any;
     }): void;
-    /**
-     * Alias of this.$isNew.
-     */
-    get isNew(): boolean;
     /**
      * Returns whether the current loaded data represent a stored db record.
      */

diff --git a/dist/pocketbase.iife.js b/dist/pocketbase.iife.js
diff --git a/dist/pocketbase.iife.js.map b/dist/pocketbase.iife.js.map
diff --git a/dist/pocketbase.umd.d.ts b/dist/pocketbase.umd.d.ts
@@ -29,10 +29,6 @@ declare abstract class BaseModel {
     $load(data: {
         [key: string]: any;
     }): void;
-    /**
-     * Alias of this.$isNew.
-     */
-    get isNew(): boolean;
     /**
      * Returns whether the current loaded data represent a stored db record.
      */

diff --git a/dist/pocketbase.umd.js b/dist/pocketbase.umd.js
diff --git a/dist/pocketbase.umd.js.map b/dist/pocketbase.umd.js.map
diff --git a/package.json b/package.json
@@ -1,5 +1,5 @@
 {
-    "version": "0.14.3",
+    "version": "0.14.4-rc",
     "name": "pocketbase",
     "description": "PocketBase JavaScript SDK",
     "author": "Gani Georgiev",

diff --git a/src/models/utils/BaseModel.ts b/src/models/utils/BaseModel.ts
@@ -30,13 +30,6 @@ export default abstract class BaseModel {
         this.updated = typeof data.updated !== 'undefined' ? data.updated : '';
     }
 
-    /**
-     * Alias of this.$isNew.
-     */
-    get isNew(): boolean {
-        return this.$isNew
-    }
-
     /**
      * Returns whether the current loaded data represent a stored db record.
      */