Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Compass types and errors #92

Merged
merged 8 commits into from
Mar 18, 2024
Merged

Conversation

jm42
Copy link
Member

@jm42 jm42 commented Mar 18, 2024

Description

The compass error management was not good to understand what was happening under. It had some problems like doing a response.json when the status code is not 200, double-throw without needed in request/fetchGraphQL and the catch was for everything instead of more fine-grained problems. Now there is a custom error that will return GraphQL errors. Also, changed the use of any for unknown and remove the ts-ignore.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.

@jm42 jm42 requested a review from rlajous March 18, 2024 09:04
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for eloquent-alpaca-5d321f canceled.

Name Link
🔨 Latest commit 2a01abc
🔍 Latest deploy log https://app.netlify.com/sites/eloquent-alpaca-5d321f/deploys/65f8065600c97e0008429d12

@jm42 jm42 self-assigned this Mar 18, 2024
@jm42 jm42 changed the base branch from main to release/v0.1.6 March 18, 2024 15:44
@jm42 jm42 merged commit 75158e2 into release/v0.1.6 Mar 18, 2024
5 checks passed
@jm42 jm42 deleted the fix/compass-types-and-errors branch March 18, 2024 15:44
@jm42 jm42 mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants