Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-1395 Change Axios and Form-data by requiring minimum node version #63

Merged
merged 9 commits into from
Sep 28, 2023
Merged

PLT-1395 Change Axios and Form-data by requiring minimum node version #63

merged 9 commits into from
Sep 28, 2023

Conversation

rlajous
Copy link
Member

@rlajous rlajous commented Sep 8, 2023 •
edited
Loading

Description

Please provide a short description of the changes in this pull request.

Fixes issues:
#44
#43

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Sep 8, 2023 •
edited
Loading

✅ Deploy Preview for eloquent-alpaca-5d321f canceled.

Name Link
🔨 Latest commit 7c7ae03
🔍 Latest deploy log https://app.netlify.com/sites/eloquent-alpaca-5d321f/deploys/6514063afba54a000855d470

@rlajous rlajous changed the title PLT-1395 Added basic changes PLT-1395 Change Axios and Form-data by requiring minimum node version Sep 8, 2023
jm42
jm42 reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@jm42 jm42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not v18 directly?

image

@rlajous rlajous merged commit c23696e into main Sep 28, 2023
4 checks passed
@rlajous rlajous deleted the PLT-1395-implement-the-solution-implement-the-solution-5-pts-tbd-when-investigation-finish branch September 28, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm42 jm42 jm42 left review comments

@alavarello alavarello alavarello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlajous @jm42 @alavarello