Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Drop from Compass without Image #145

Merged
merged 9 commits into from
Nov 19, 2024
Merged

Fix Drop from Compass without Image #145

merged 9 commits into from
Nov 19, 2024

Conversation

jm42
Copy link
Member

@jm42 jm42 commented Nov 18, 2024

Description

This fixes when a Drop has no drop_image returned.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.

@jm42 jm42 requested review from reobin, nacho9900 and rlajous November 18, 2024 05:30
@jm42 jm42 self-assigned this Nov 18, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
poap-js ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 2:57am

@jm42 jm42 merged commit fc6bc58 into main Nov 19, 2024
3 checks passed
@jm42 jm42 deleted the fix-drop-image-without-gateways branch November 19, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reobin reobin reobin approved these changes

@nacho9900 nacho9900 Awaiting requested review from nacho9900

@rlajous rlajous Awaiting requested review from rlajous

Assignees

@jm42 jm42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jm42 @reobin