Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Link issues properly in pull request template #141

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

reobin
Copy link
Member

@reobin reobin commented Oct 23, 2024

Description

When using "Closes" instead of "Fixes", a proper link is added to the issue and upon merging the PR, the issue will automatically be closed.

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.

When using "Closes" instead of "Fixes", a proper link is added to the
issue and upon merging the PR, the issue will automatically be closed.
@reobin reobin requested review from jm42 and rlajous October 23, 2024 16:38
@reobin reobin self-assigned this Oct 23, 2024
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
poap-js ⬜️ Ignored (Inspect) Oct 23, 2024 4:38pm

@reobin reobin merged commit 110ca0c into main Oct 23, 2024
3 checks passed
@reobin reobin deleted the chore/pr-template branch October 23, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants