Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Adapt Moments package to POAP Moments API v2 #139

Merged
merged 8 commits into from
Oct 21, 2024
Merged

refactor: Adapt Moments package to POAP Moments API v2 #139

merged 8 commits into from
Oct 21, 2024

Conversation

reobin
Copy link
Member

@reobin reobin commented Oct 18, 2024

Description

  • Change drop ID to drop IDs in fetch and create Moments functions
  • Remove CID property
  • Remove token ID property
  • Remove update Moment function

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.

@reobin reobin requested review from jm42, nacho9900 and rlajous October 18, 2024 20:50
@reobin reobin self-assigned this Oct 18, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
poap-js ⬜️ Ignored (Inspect) Oct 18, 2024 8:50pm

@reobin reobin changed the title refactor: Adapt Moments to POAP Moments API v2 refactor: Adapt Moments package to POAP Moments API v2 Oct 18, 2024
jm42
jm42 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@jm42 jm42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@reobin reobin merged commit b7864a2 into main Oct 21, 2024
3 checks passed
@reobin reobin deleted the feat/moments-api-v2 branch October 21, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nacho9900 nacho9900 nacho9900 approved these changes

@jm42 jm42 jm42 approved these changes

@rlajous rlajous Awaiting requested review from rlajous

Assignees

@reobin reobin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reobin @jm42 @nacho9900