Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Moments): Add function to create Moment without uploading media #135

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

reobin
Copy link
Member

@reobin reobin commented Oct 4, 2024

Description

  • Rename createMoment to createMomentAndUploadMedia
  • Create new createMoment function to create a Moment without uploading media.
  • Change visibility to public for uploadMedia and awaitForMediaProcessing
    • Allows clients to upload media separately from Moments creation

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.

* Rename `createMoment` to `createMomentAndUploadMedia`
* Create new `createMoment` function to create a Moment without uploading media.
* Change visibility to `public` for `uploadMediaList` and `awaitForMediaProcessing`
  * Allows clients to upload media separately from Moments creation
* Adjust MomentsClient unit tests
@reobin reobin requested a review from nacho9900 October 4, 2024 17:54
@reobin reobin self-assigned this Oct 4, 2024
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
poap-js ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 6:06pm

@reobin reobin merged commit a9d7528 into main Oct 4, 2024
3 checks passed
@reobin reobin deleted the feat/moments-upload branch October 4, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants